gaviota.py: simplify and improve code #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are apparently lines not covered by the tests that mypy was able to catch. I am open to modifying the code if it needs improvement. |
MarkZH
reviewed
Jan 6, 2025
|
Thanks, looks good! Will test offline with a larger test suite just to be sure. |
|
Found #1132 (happy if someone wants to take a look), but that's not a regression. So merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @niklasf, I was having a look at the code to understand how endgame databases work and I saw that the Gaviota part of the code could be improved. Here is a first step:
The whole structure is the same so the PR should hopefully be easy enough to review. The tests pass and the code should also run faster.