add iOSOpenSettinfsOnDeny option to requestAuthorization to make opening the settings on subsequent calls after the user denied permission optional

README.md

@@ -130,7 +130,7 @@ cordova.plugins.photoLibrary.getLibrary(
 requestAuthorization is cross-platform method, that works in following way:
 
 - On android, will ask user to allow access to storage
-- On ios, on first call will open permission prompt. If user denies it subsequent calls will open setting page of your app, where user should enable access to Photos.
+- On ios, on first call will open permission prompt. If user denies it and `iOSOpenSettingsOnDeny` is set to `true` (default) subsequent calls will open setting page of your app, where user should enable access to Photos.
 
 ```js
 cordova.plugins.photoLibrary.requestAuthorization(
@@ -142,7 +142,8 @@ cordova.plugins.photoLibrary.requestAuthorization(
   }, // if options not provided, defaults to {read: true}.
   {
     read: true,
-    write: true
+    write: true,
+    iOSOpenSettingsOnDeny: true
   }
 );
 ```

src/ios/PhotoLibrary.swift

@@ -246,13 +246,15 @@ import Foundation
 
         let service = PhotoLibraryService.instance
 
+        let options = command.arguments[0] as! NSDictionary
+        let openSettingsOnDeny = options["iOSOpenSettingsOnDeny"] as! Bool
         service.requestAuthorization({
             let pluginResult = CDVPluginResult(status: CDVCommandStatus_OK)
             self.commandDelegate!.send(pluginResult, callbackId: command.callbackId	)
         }, failure: { (err) in
             let pluginResult = CDVPluginResult(status: CDVCommandStatus_ERROR, messageAs: err)
             self.commandDelegate!.send(pluginResult, callbackId: command.callbackId	)
-        })
+        }, openSettingsOnDeny: openSettingsOnDeny )
 
     }
 

src/ios/PhotoLibraryService.swift

@@ -561,7 +561,7 @@ final class PhotoLibraryService {
 
     }
 
-    func requestAuthorization(_ success: @escaping () -> Void, failure: @escaping (_ err: String) -> Void ) {
+    func requestAuthorization(_ success: @escaping () -> Void, failure: @escaping (_ err: String) -> Void, openSettingsOnDeny: Bool ) {
 
         let status = PHPhotoLibrary.authorizationStatus()
 
@@ -583,14 +583,18 @@ final class PhotoLibraryService {
             return
         }
 
-        // Permission was manually denied by user, open settings screen
-        let settingsUrl = URL(string: UIApplicationOpenSettingsURLString)
-        if let url = settingsUrl {
-            UIApplication.shared.openURL(url)
-            // TODO: run callback only when return ?
-            // Do not call success, as the app will be restarted when user changes permission
+        if (openSettingsOnDeny) {
+            // Permission was manually denied by user, open settings screen
+            let settingsUrl = URL(string: UIApplicationOpenSettingsURLString)
+            if let url = settingsUrl {
+                UIApplication.shared.openURL(url)
+                // TODO: run callback only when return ?
+                // Do not call success, as the app will be restarted when user changes permission
+            } else {
+                failure("could not open settings url")
+            }
         } else {
-            failure("could not open settings url")
+            failure("user denied photo access before")
         }
 
     }

www/PhotoLibrary.js

@@ -322,8 +322,9 @@ var getRequestAuthenticationOptionsWithDefaults = function (options) {
   }
 
   options = {
-    read: options.read || true,
+    read: options.read === undefined ? true : options.read,
     write: options.write || false,
+    iOSOpenSettingsOnDeny: options.iOSOpenSettingsOnDeny === undefined ? true : options.iOSOpenSettingsOnDeny,
   };
 
   return options;