Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup channels and make them compile on devel #70

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

planetis-m
Copy link
Contributor

Copied the logic from memalloc. I could be wrong about the MemAlign const

@planetis-m
Copy link
Contributor Author

ready.

@Araq
Copy link
Member

Araq commented Aug 11, 2024

The change looks nice but why was it necessary?

@planetis-m
Copy link
Contributor Author

@Araq the idea was to make it similar to ref/seq[t] But I guess it's not necessary given the default alignment guarantees of malloc. This change can be merged/reviewed now, as it contains some improvements without the alignment part.

@planetis-m planetis-m changed the title Add alignment to channels and fix for devel Cleanup channels and make them compile on devel Aug 12, 2024
@Araq Araq merged commit d8f0c4f into nim-lang:master Aug 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants