-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#56] Separate typescript to dedicated package #68
Conversation
Separate typescript to dedicated package Update package and linting
d3a63d9
to
d826b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved ahead with 2 minor typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great one ✨, I think we should extend the @nimblehq/eslint-config-nimble-typescript
in the testing
and react
packages, otherwise, other dependent projects will lose the Typescript
config in the next update 👍
The rest already looks good to me.
Co-authored-by: Tyson <[email protected]>
efd71ee
to
c5c760f
Compare
c5c760f
to
ba14ccd
Compare
What happened 👀
As some projects don't have built-in
typescript
such as Rails, we need to separatetypescript
rules from thecore
package. Later, for those who need the rules for typescript, we need to extend it explicitly.typescript
to a dedicated package namedeslint-config-nimble-typescript
Insight 📝
n/a
Proof Of Work 📹