Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#56] Separate typescript to dedicated package #68

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

sanG-github
Copy link
Contributor

@sanG-github sanG-github commented Jan 15, 2024

What happened 👀

As some projects don't have built-in typescript such as Rails, we need to separate typescript rules from the core package. Later, for those who need the rules for typescript, we need to extend it explicitly.

  • Separate typescript to a dedicated package named eslint-config-nimble-typescript
  • Update the README
  • Release the new package

Insight 📝

n/a

Proof Of Work 📹

Ran it successfully on local
image

Separate typescript to dedicated package

Update package and linting
@sanG-github sanG-github force-pushed the bug/gh56-separate-typescript-package branch from d3a63d9 to d826b4c Compare January 25, 2024 04:06
@sanG-github sanG-github marked this pull request as ready for review January 25, 2024 04:06
@sanG-github sanG-github requested review from carryall and a team as code owners January 25, 2024 04:06
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ahead with 2 minor typos

packages/eslint-config-nimble-typescript/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one ✨, I think we should extend the @nimblehq/eslint-config-nimble-typescript in the testing and react packages, otherwise, other dependent projects will lose the Typescript config in the next update 👍
The rest already looks good to me.

@sanG-github sanG-github requested a review from nvminhtue January 26, 2024 06:59
@sanG-github sanG-github force-pushed the bug/gh56-separate-typescript-package branch from efd71ee to c5c760f Compare January 26, 2024 09:18
@sanG-github sanG-github force-pushed the bug/gh56-separate-typescript-package branch from c5c760f to ba14ccd Compare January 26, 2024 09:20
@carryall carryall merged commit 06a6b3a into develop Mar 13, 2024
1 check passed
@carryall carryall deleted the bug/gh56-separate-typescript-package branch March 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Failed to load plugin '@typescript-eslint'
4 participants