[#74] Update Node

[malparty]

• Close Update to Node 22 #74

What happened 👀

• Use Node 22
• Update some dependencies
• Resolved vulnerabilities from dependencies

Insight 📝

I'm not sure how to "test" these versions on my project, without publishing the npm package first... So if you know, let me know so I can test before we merge :harold:

Proof Of Work 📹

Before	After

[jtotty]

@malparty Just throwing an idea here: you can try using npm-link to test the packages locally in a repository that is dependent on them before publishing. I'm just quickly checking if it actually works.

https://docs.npmjs.com/cli/v9/commands/npm-link

[jtotty]

@malparty There's two ways you can do this locally with npm-link or npm-pack. While this requires manual testing and isn't the most reliable approach, it's an option.

npm-link
Creates a symlink to the package.
https://docs.npmjs.com/cli/v9/commands/npm-link

1. In the individual package directory run npm link.
2. cd into the root directory of a project and make sure you are using the correct nodejs version. Note: If you are using a version manager like nvm or asdf it won't use the symlinked package if there is a node version mismatch. It will install the published package specified in package.json as standard.
3. Delete the node_modules folder
4. Run npm link @nimblehq/eslint-config-nimble-core - this runs npm install and uses the symlinked package.

To unlink run npm unlink --no-save @nimblehq/eslint-config-nimble-core

npm-pack
Create a tarball from a package
https://docs.npmjs.com/cli/v9/commands/npm-pack

1. In the individual package directory run npm pack --pack-destination <filepath>
2. Update the package.json in the project to use the tarball. E.g. "@nimblehq/eslint-config-nimble-core": "file:~/temp_npm_pack/nimblehq-eslint-config-nimble-core-2.8.2.tgz"
3. Delete the node_modules folder
4. Run npm install

[malparty]

@jtotty thanks a lot for your insights!! 🚀

I did a first try with npm link though ESLint fails to get the reference:

Oops! Something went wrong! :(

ESLint: 8.57.0

Error: Cannot read config file: /Users/xavier/Documents/Source/eslint-config-nimble/packages/eslint-config-nimble-react/lib/rules/base.js
Error: Cannot find module '@nimblehq/eslint-config-nimble-core'
Require stack:
- /Users/xavier/Documents/Source/eslint-config-nimble/packages/eslint-config-nimble-react/lib/rules/base.js
- /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
- /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint/lib/cli-engine/cli-engine.js
- /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint/lib/eslint/eslint.js
- /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint/lib/eslint/index.js
- /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint/lib/cli.js
- /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint/bin/eslint.js

So it's tuff!

I was able to fix these imports by adding require.resolve to them...

• First we need to run npm link is ALL the packages (core, typescript, react & testing)
• Then also run npm link inside the react eslint package (subfolder in this repo) npm link @nimblehq/eslint-config-nimble-core @nimblehq/eslint-config-nimble-typescript
• Finally link these packages to my project: `npm link @nimblehq/eslint-config-nimble-core @nimblehq/eslint-config-nimble-testing @nimblehq/eslint-config-nimble-react @nimblehq/eslint-config-nimble-typescript

Now it's pointing at prettier resolution... And I'm out of time, so I'll stop there for now 🙇

[Info  - 5:52:40 PM] ESLint server is starting.
[Info  - 5:52:40 PM] ESLint server running in node v20.16.0
[Info  - 5:52:40 PM] ESLint server is running.
[Info  - 5:52:40 PM] ESLint library loaded from: /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint/lib/api.js
[Error - 5:52:40 PM] Calculating config file for file:///Users/xavier/Documents/Source/jfc-global-templates-web/package-lock.json) failed.
Error: Failed to load config "prettier" to extend from.
Referenced from: /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js
    at configInvalidError (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2648:9)
    at ConfigArrayFactory._loadExtendedShareableConfig (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3279:23)
    at ConfigArrayFactory._loadExtends (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3156:25)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
    at _normalizeObjectConfigData.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (/Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
[Error - 5:52:40 PM] Request textDocument/diagnostic failed.
  Message: Request textDocument/diagnostic failed with message: Failed to load config "prettier" to extend from.
Referenced from: /Users/xavier/Documents/Source/jfc-global-templates-web/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js
  Code: -32603 

---

npm pack could work, but it's a LOT to do for testing and fixing any issue 🥲