[#6] Fix syntax

nimblehq · Nov 24, 2023 · cf3cd8a · cf3cd8a
1 parent 173bb3a
commit cf3cd8a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml
@@ -3,7 +3,6 @@ on:
   push:
     branches:
       - main
-      - feature/6-set-up-cd-android
 
 jobs:
   deploy_android:
@@ -36,21 +35,21 @@ jobs:
             ${{ runner.os }}-gradle-
 
       - name: Decode singing properties
-        run: echo ${{ secrets.ANDROID_SIGNING_PROPERTIES }} | base64 --decode > signing.properties
+        run: echo "${{ secrets.ANDROID_SIGNING_PROPERTIES }}" | base64 --decode > signing.properties
 
       - name: Decode release keystore
         run: echo "${{ secrets.ANDROID_RELEASE_KEYSTORE }}" | base64 --decode > config/release.keystore
 
       - name: Decode buildKonfig properties
-        run: echo ${{ secrets.BUILD_KONFIG_PROPERTIES }} | base64 --decode > buildKonfig.properties
+        run: echo "${{ secrets.BUILD_KONFIG_PROPERTIES }}" | base64 --decode > buildKonfig.properties
 
       - name: Build production APK
         run: ./gradlew assembleProductionRelease -PversionCode=$GITHUB_RUN_NUMBER
 
       - name: Deploy production to Firebase
         uses: wzieba/[email protected]
         with:
-          appId: ${{env.ANDROID_FIREBASE_APP_ID}}
+          appId: ${{ vars.ANDROID_FIREBASE_APP_ID }}
           serviceCredentialsFileContent: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIAL_FILE_CONTENT }}
           groups: nimble
           file: sample/android/build/outputs/apk/production/release/android-production-release.apk
diff --git a/.github/workflows/deploy_staging.yml b/.github/workflows/deploy_staging.yml
@@ -3,7 +3,6 @@ on:
   push:
     branches:
       - develop
-      - feature/6-set-up-cd-android
 
 jobs:
   deploy_android:
@@ -36,15 +35,15 @@ jobs:
             ${{ runner.os }}-gradle-
 
       - name: Decode buildKonfig properties
-        run: echo ${{ secrets.BUILD_KONFIG_PROPERTIES }} | base64 --decode > buildKonfig.properties
+        run: echo "${{ secrets.BUILD_KONFIG_PROPERTIES }}" | base64 --decode > buildKonfig.properties
 
       - name: Build staging APK
         run: ./gradlew assembleStagingDebug -PversionCode=$GITHUB_RUN_NUMBER
 
       - name: Deploy staging to Firebase
         uses: wzieba/[email protected]
         with:
-          appId: ${{env.ANDROID_FIREBASE_APP_ID}}
+          appId: ${{ vars.ANDROID_FIREBASE_APP_ID }}
           serviceCredentialsFileContent: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIAL_FILE_CONTENT }}
           groups: nimble
           file: sample/android/build/outputs/apk/staging/debug/android-staging-debug.apk