Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Sync main and develop #52

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Conversation

phongvhd93
Copy link
Collaborator

What happened 👀

Sync main and develop branch

Insight 📝

N/A

Proof Of Work 📹

The template works as expected

Screenshot 2024-01-02 at 16 03 36

Copy link

github-actions bot commented Jan 2, 2024

8 Warnings
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
⚠️ shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
⚠️ shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
⚠️ shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
⚠️ shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Gemfile.lock
Podfile.lock
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

Copy link

github-actions bot commented Jan 2, 2024

Current coverage for sample is 18.25%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

@phongvhd93
Copy link
Collaborator Author

@luongvo , please check this

@phongvhd93 phongvhd93 merged commit b450d4f into develop Jan 15, 2024
2 checks passed
@phongvhd93 phongvhd93 deleted the chore/sync-main-and-develop branch January 15, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants