Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.4.0 #53

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Release - 0.4.0 #53

merged 8 commits into from
Jan 16, 2024

Conversation

phongvhd93
Copy link
Collaborator

@phongvhd93 phongvhd93 added this to the 0.4.0 milestone Jan 15, 2024
@phongvhd93 phongvhd93 self-assigned this Jan 15, 2024
@github-actions GitHub Actions
Copy link

9 Warnings
⚠️ Big PR
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
⚠️ shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
⚠️ shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
⚠️ shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
⚠️ shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Gemfile.lock
Podfile.lock
deploy_production.yml
deploy_production.yml
deploy_staging.yml
deploy_staging.yml
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link

1 Warning
⚠️ This pull request is quite big (727 lines changed), please consider splitting it into multiple pull requests.

Current coverage for sample is 18.25%

✅ No files affecting coverage found

Powered by xcov

Generated by 🚫 Danger

@phongvhd93 phongvhd93 merged commit 72b437d into main Jan 16, 2024
2 checks passed
@phongvhd93 phongvhd93 deleted the release/0.4.0 branch January 16, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgravity markgravity markgravity approved these changes

@luongvo luongvo luongvo approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@lydiasama lydiasama Awaiting requested review from lydiasama

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

Assignees

@phongvhd93 phongvhd93

Labels
type : release
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@phongvhd93 @luongvo @markgravity @bot-nimble