[#473] Revise the Flow for Asking Options to generate the project #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanG-github
force-pushed
the
feature/gh473-optimize-generating-flow
branch
from
b2015f1 to
46ea2d2
Compare
sanG-github
force-pushed
the
feature/gh473-optimize-generating-flow
branch
from
bc87a2f to
ec8ad95
Compare
sanG-github
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
malparty and
tyrro
as code owners
malparty
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
At first I wanted to suggest to move the ask_for_optional_addons call earlier, but then I saw it better for the UX to have the message about the default add-ons installations, so that it's clear what is already configure when the user select the optional addons.
So all good!
PR: just the proof of work is wrong for the Web variant, it displays the prompt of the API variant instead of:
olivierobert
approved these changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #473
What happened 👀
Enhance the flow to generate the project by using
@instance_variableto remember the user's options for each addon.Then we install all the necessary addons based on these variables's values.
Insight 📝
n/aProof Of Work 📹