Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Deprecation of the script to install NodeJS & Yarn from nodesource #487

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix: Deprecation of the script to install NodeJS & Yarn from nodesource #487

merged 3 commits into from
Dec 7, 2023

Conversation

longnd
Copy link
Contributor

@longnd longnd commented Dec 5, 2023 •
edited
Loading

close #476

What happened 👀

Insight 📝

# Install a specific version of Node.js. Replace '<version>' with the desired version number
apt-get install nodejs=<version>

# Example: install Node.js version 18.16.0-1nodesource1
apt-get install nodejs=18.16.0-1nodesource1

Proof Of Work 📹

The test on web variant generated the docker build successfully
https://github.com/nimblehq/rails-templates/actions/runs/7097180699/job/19316878664?pr=487#step:14:839
image

@longnd longnd self-assigned this Dec 5, 2023
@longnd longnd changed the title DSC_3221.JPG Fix: Deprecation of the script to install NodeJS & Yarn from nodesource Dec 5, 2023
@longnd longnd force-pushed the bug/gh-475-fix-deprecation-warning branch from ef325a4 to 88ed4df Compare December 5, 2023 06:42
@longnd longnd force-pushed the bug/gh-475-fix-deprecation-warning branch from 88ed4df to d817fd6 Compare December 5, 2023 06:46
@longnd longnd marked this pull request as ready for review December 5, 2023 07:13
malparty
malparty approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@malparty malparty added this to the 5.11.0 milestone Dec 5, 2023
@malparty malparty added this pull request to the merge queue Dec 7, 2023
Merged via the queue into develop with commit 7cb441c Dec 7, 2023
5 checks passed
@malparty malparty deleted the bug/gh-475-fix-deprecation-warning branch December 7, 2023 09:49
@malparty malparty mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@olivierobert olivierobert olivierobert approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@tyrro tyrro Awaiting requested review from tyrro

@sanG-github sanG-github Awaiting requested review from sanG-github sanG-github is a code owner

Assignees

@longnd longnd

Labels
type : chore
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.

Fix: Deprecation of the script to install NodeJS & Yarn from nodesource
3 participants
@longnd @olivierobert @malparty