Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#429] Revisit the test workflow #501

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

sanG-github
Copy link
Contributor

@sanG-github sanG-github commented Jan 10, 2024

What happened 👀

Revised the test workflow, at the step using the branch-tag-action workflow.

Based on the current implementation of the branch-tag-action workflow, it should be develop instead of development since the BRANCH_TAG depends on the branch or tag.

if [[ $BRANCH_NAME == master || $BRANCH_NAME == main ]]
then
    BRANCH_TAG=latest
elif [[ $TAG_NAME != $REF ]]
then
    BRANCH_TAG=$TAG_NAME
else
    BRANCH_TAG="${BRANCH_NAME//\//-}"
fi

Insight 📝

n/a

Proof Of Work 📹

Small change as described in the above section.

Copy link
Contributor

@Goose97 Goose97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@malparty malparty added this pull request to the merge queue Jan 11, 2024
Merged via the queue into develop with commit 8706c11 Jan 11, 2024
5 checks passed
@malparty malparty deleted the feature/gh429-revise-test-workflow branch January 11, 2024 04:33
@malparty malparty mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the test workflow
3 participants