Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release – 5.13.0 #508

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Release – 5.13.0 #508

merged 2 commits into from
Mar 18, 2024

Conversation

malparty
Copy link
Member

@5.13.0

Features

Chores

n/a

Bugs

n/a

New Contributors

Full Changelog: 5.12.0...5.13.0

malparty and others added 2 commits March 7, 2024 07:13
@malparty
Add a Bootstrap layout to the CRUD add-on (#485)
cf33fad 
* [#483] Add the first version of the CRUD addon with a simple bootstrap layout

* [#483] Add tests to the CRUD layout

* [#483] Fix the check for slim and erb layout files

* Fix lint issues

* Makes error condition more explicit

* Fix rubocop issue
@khangbui22 @malparty
[#492][CRUD] Add the index view templates to the generator (#505)
688614e 
* [#483] Add tests to the CRUD layout

* [#483] Fix the check for slim and erb layout files

* [#492] Update Gemfile to include slim-rails instead of slim

* [#492] Update template code and slim template index file

* [#492] Fix rubocop issue

* [#492] Fix spec test

* [#492] Improve copy_template_files function for easier readability

* [#492] Fix rubocop error

* [#492] Remove unused method

* [#492] Move ThorUtils to a lib

* [#492] Fix rubocop

* [#492] Fix rubocop

---------

Co-authored-by: Xavier MALPARTY <[email protected]>
@malparty malparty added this to the 5.13.0 milestone Mar 14, 2024
@malparty malparty self-assigned this Mar 14, 2024
@malparty malparty requested a review from a user March 14, 2024 06:24
@malparty malparty requested a review from sanG-github as a code owner March 14, 2024 06:24
khangbui22
khangbui22 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@khangbui22 khangbui22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@malparty malparty merged commit e824355 into main Mar 18, 2024
15 checks passed
@malparty malparty deleted the release/5.13.0 branch March 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanG-github sanG-github sanG-github approved these changes

@khangbui22 khangbui22 khangbui22 approved these changes

@aetheryna aetheryna Awaiting requested review from aetheryna aetheryna is a code owner

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@Goose97 Goose97 Awaiting requested review from Goose97 Goose97 is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@tyrro tyrro Awaiting requested review from tyrro

Assignees

@malparty malparty

Labels
type : release
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@malparty @khangbui22 @sanG-github