Add AWS RDS configuration with PostgreSQL instance, security group #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leej3
requested changes
Jan 9, 2025
.github/workflows/terraform.yml
Outdated
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
|
|
There was a problem hiding this comment.
Use OIDC here by adding this step:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: ${{ secrets.AWS_REGION }}
role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT_ID }}:role/github-actions-role-shared
There was a problem hiding this comment.
Hello @leej3, where we store AWS_ACCOUNT_ID and AWS_REGION value?
.github/workflows/terraform.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
change this to use manual dispatch. We may only deploy it once but we'll see how things go. No doubt we'll be running it a few times on this PR to make sure things are working well.
.github/workflows/terraform.yml
Outdated
| working-directory: ./terraform/state | ||
|
|
||
| - name: Terraform Apply | ||
| if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/terraform-sharing-db' |
There was a problem hiding this comment.
remove this, so that manual dispatch will work.
| { | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "rds:CreateDBInstance", |
There was a problem hiding this comment.
we may have to modify the permissions here. Let me know if that is required.
leej3
force-pushed
the
teraform-sharing-db
branch
from
910aa15 to
14a375e
Compare
leej3
force-pushed
the
teraform-sharing-db
branch
from
14a375e to
654db63
Compare
leej3
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.