-
Notifications
You must be signed in to change notification settings - Fork 208
Conversation
5e14864
to
5d0f4ef
Compare
cc5afef
to
71cbe71
Compare
71cbe71
to
11796d7
Compare
let result = await $.client.sendTransaction(transaction); | ||
|
||
console.log(' Transaction result: '); | ||
console.log(result); | ||
|
||
console.log(' Transaction hash: '); | ||
console.log(transaction.hash().toHex()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each further transaction sending should maybe fail, if a tx fails to send? E.g. if it reports as result.state === 'new'
?
If the txs are all in the same block, their order is not guaranteed I think. Is the PoS genesis-generating script able to work with unsorted transactions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, since they are 0 value txns they should not fail..
The PoS generation script is able to work with unsorted transactions:
As part of the encoding that we created for the tx data, we are using 1 byte as "type" which is just a number to indicate the order of the registration txn. So the migration tool will look this number to sort the registration txns.
91766ef
to
7cae0ec
Compare
57ca81b
to
2c4c1a0
Compare
2c4c1a0
to
8ccc144
Compare
This NodeJS script is used to register validators for the Nimiq PoS chain The script itself is a nano node that will automatically connect to the Nimiq PoW chain and send the required validator registration transactions. Note: The Validator Account needs to have enough funds to pay the transactions
8ccc144
to
7d72573
Compare
The tool discussed in this PR was moved to its own repository: https://github.com/nimiq/validator-registration-tool. Closing the PR as it is no longer relevant for core-js. |
This NodeJS script is used to register validators for the Nimiq PoS chain The script itself is a nano node that will automatically connect to the Nimiq PoW chain and send the required validator registration transactions. Note: The Validator Account needs to have enough funds to pay the transaction
Pull request checklist