Extend transaction topic mesh to non-validator nodes #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paberr
force-pushed
the
pb/mesh
branch
2 times, most recently
from
ff27199 to
642fafc
Compare
|
Does this address #2625? Or is that another mechanism besides the transaction topic? |
|
That's a different thing, the mempool is still not synced (it's only synced accidentally). |
|
What is the transaction topic then, if not a way of exchanging transactions between nodes? I would think that's only relevant for mempool tx, as after inclusion the included txs are shared via their blocks on the block topic. |
As you say it is for transmission of transactions between nodes but this transmission doesn't warrant any synchronicity between them. |
jsdanielh
reviewed
Jun 25, 2024
hrxi
reviewed
Jun 26, 2024
|
Addressed all comments so far. |
Always initialize mempool for history/full nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR extends the nodes that listen to and validate transactions on the network.
This is done by:
This fixes #2615.
Pull request checklist
clippyandrustfmtwarnings.