Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused dependencies #2836

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Remove some unused dependencies #2836

merged 1 commit into from
Aug 19, 2024

Conversation

jsdanielh
Copy link
Member

Remove some unused dependencies in these crates:

  • bls
  • network-libp2p
  • test-uitls
  • utils

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

utils/Cargo.toml Outdated
@@ -21,11 +21,9 @@ workspace = true

[dependencies]
clear_on_drop = { version = "0.2", optional = true }
futures = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with #2798.

@jsdanielh jsdanielh force-pushed the jsdanielh/deps branch 2 times, most recently from 631479d to 7c8edb0 Compare August 19, 2024 10:14
Remove some unused dependencies in these crates:
- `bls`
- `network-libp2p`
- `test-uitls`
- `utils`
Copy link
Contributor

@hrxi hrxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@jsdanielh jsdanielh merged commit 49b9c74 into albatross Aug 19, 2024
7 checks passed
@jsdanielh jsdanielh deleted the jsdanielh/deps branch August 19, 2024 15:14
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants