Only allow pizza-ninjas inscriptions

ninja5pizza · Jan 10, 2025 · feeb20a · feeb20a
1 parent ab743cc
commit feeb20a
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 2 deletions.
diff --git a/app/Http/Controllers/CollectionController.php b/app/Http/Controllers/CollectionController.php
@@ -3,13 +3,18 @@
 namespace App\Http\Controllers;
 
 use App\Models\Inscription;
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\View\View;
 
 class CollectionController extends Controller
 {
     public function __invoke(): View
     {
-        $inscriptions = Inscription::orderBy('name')->paginate(5);
+        $inscriptions = Inscription::whereHas('collection', function (Builder $query) {
+            $query->where('slug', 'pizza-ninjas');
+        })
+            ->orderBy('name')
+            ->paginate(5);
 
         return view('collection', [
             'inscriptions' => $inscriptions,

diff --git a/app/Http/Controllers/InscriptionController.php b/app/Http/Controllers/InscriptionController.php
@@ -9,6 +9,10 @@ class InscriptionController extends Controller
 {
     public function __invoke(Inscription $inscription): View
     {
+        if (! $inscription->collection || $inscription->collection->slug !== 'pizza-ninjas') {
+            abort(404);
+        }
+
         return view('inscription', [
             'inscription' => $inscription,
         ]);

diff --git a/app/Http/Controllers/SearchController.php b/app/Http/Controllers/SearchController.php
@@ -3,6 +3,7 @@
 namespace App\Http\Controllers;
 
 use App\Models\Inscription;
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Str;
@@ -21,7 +22,10 @@ public function __invoke(Request $request): RedirectResponse
 
         $query = Str::of($validated['query'])->after('#')->toString();
 
-        $inscription = Inscription::where('name', 'LIKE', "%#{$query}")
+        $inscription = Inscription::whereHas('collection', function (Builder $query) {
+            $query->where('slug', 'pizza-ninjas');
+        })
+            ->where('name', 'LIKE', "%#{$query}")
             ->orWhere('inscription_id', $query)
             ->orderBy('name')
             ->first();

diff --git a/tests/Feature/ViewInscriptionPageTest.php b/tests/Feature/ViewInscriptionPageTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Feature;
 
 use App\Models\Inscription;
+use App\Models\OrdinalsCollection;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use PHPUnit\Framework\Attributes\Test;
 use Tests\TestCase;
@@ -14,7 +15,12 @@ class ViewInscriptionPageTest extends TestCase
     #[Test]
     public function a_request_to_the_inscription_page_should_return_a_200_status_code(): void
     {
+        $collection = OrdinalsCollection::factory()->create([
+            'slug' => 'pizza-ninjas',
+        ]);
+
         Inscription::factory()->create([
+            'collection_id' => $collection->id,
             'inscription_id' => '9ad43b591e58b23d8550dfdae431432b6ea3a7079d09ef80ee1554c5a3f8d543i0',
         ]);
 
@@ -23,10 +29,31 @@ public function a_request_to_the_inscription_page_should_return_a_200_status_cod
             ->assertViewIs('inscription');
     }
 
+    #[Test]
+    public function a_request_to_an_inscription_page_not_belonging_to_pizza_ninjas_collection_should_return_a_404(): void
+    {
+        $otherCollection = OrdinalsCollection::factory()->create([
+            'slug' => 'some-other-collection',
+        ]);
+
+        Inscription::factory()->create([
+            'collection_id' => $otherCollection->id,
+            'inscription_id' => '9ad43b591e58b23d8550dfdae431432b6ea3a7079d09ef80ee1554c5a3f8d543i0',
+        ]);
+
+        $this->get('/inscription/9ad43b591e58b23d8550dfdae431432b6ea3a7079d09ef80ee1554c5a3f8d543i0')
+            ->assertNotFound();
+    }
+
     #[Test]
     public function a_request_to_the_inscription_page_should_see_the_right_title_and_image(): void
     {
+        $collection = OrdinalsCollection::factory()->create([
+            'slug' => 'pizza-ninjas',
+        ]);
+
         Inscription::factory()->create([
+            'collection_id' => $collection->id,
             'inscription_id' => '1234',
             'name' => 'Pizza Ninjas #464',
         ]);