-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Consider warnings as errors when running pytest
#157
base: main
Are you sure you want to change the base?
Conversation
aeacf9c
to
f3842ff
Compare
pytest
ed057ad
to
aa05a60
Compare
I would suggest not adding -Werror for the min runs. Warnings are expected with old versions. |
aa05a60
to
74ca019
Compare
Tried different things here:
So ran out of ideas. As for
If you have a suggestion to avoid applying the option for them, I would be happy to add it. |
74ca019
to
a540f1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 65.25% 64.87% -0.38%
==========================================
Files 25 23 -2
Lines 2674 2648 -26
Branches 420 367 -53
==========================================
- Hits 1745 1718 -27
- Misses 812 816 +4
+ Partials 117 114 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You could do something like this in tox.ini: command =
pytest ... \
!min: -Werror \
{posargs:-n auto} |
a540f1c
to
0e11f80
Compare
Consider warnings as errors when running `pytest`: exclude the `min` dependencies configuration as warnings are expected with older versions.
0e11f80
to
5a45007
Compare
Consider warnings as errors when running
pytest
.