Skip to content

Commit

Permalink
fixed (un-)ordered list generation problems (disabled varargs[HtmlEle…
Browse files Browse the repository at this point in the history
…ment] procs)
  • Loading branch information
nirokay committed Dec 19, 2024
1 parent 7bcf05a commit 4f7c3f8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
7 changes: 7 additions & 0 deletions tests/test_html.nim
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,10 @@ test "Children - Adding":
footer("Thank you for reading :3")
)
check element.getChildren().len() == 4

test "(Un)Ordered lists":
let
uList: HtmlElement = unorderedList(@["eggs", "milk", "bacon"])
oList: HtmlElement = orderedList(@["eggs", "milk", "bacon"])
check $uList == "<ul><li>eggs</li><li>milk</li><li>bacon</li></ul>"
check $oList == "<ol><li>eggs</li><li>milk</li><li>bacon</li></ol>"
2 changes: 1 addition & 1 deletion websitegenerator.nimble
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Package

version = "2.2.0"
version = "2.2.1"
author = "nirokay"
description = "A static html/css generator."
license = "GPL-3.0-only"
Expand Down
4 changes: 2 additions & 2 deletions websitegenerator/common/html.nim
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,9 @@ proc option*(value, text: string): HtmlElement =
newHtmlElement("option", text).addattr("value", value).forceClosingTag()

proc ol*(children: seq[HtmlElement]): HtmlElement = newHtmlElement("ol", children).forceClosingTag() ## Ordered list element
proc ol*(children: varargs[HtmlElement]): HtmlElement = ol(children.toSeq()) ## Ordered list element
#proc ol*(children: varargs[HtmlElement]): HtmlElement = ol(children.toSeq()) ## Ordered list element
proc ul*(children: seq[HtmlElement]): HtmlElement = newHtmlElement("ul", children).forceClosingTag() ## Unordered list element
proc ul*(children: varargs[HtmlElement]): HtmlElement = ul(children.toSeq()) ## Unordered list element
#proc ul*(children: varargs[HtmlElement]): HtmlElement = ul(children.toSeq()) ## Unordered list element

proc li*(text: string): HtmlElement = newHtmlElement("li", text).forceClosingTag() ## List item element
proc li*(children: seq[HtmlElement]): HtmlElement = newHtmlElement("li", children).forceClosingTag() ## li element
Expand Down

0 comments on commit 4f7c3f8

Please sign in to comment.