Implement promise polyfill #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clovis1122
commented
Oct 6, 2020
|
|
||
| ### Question | ||
|
|
||
| Create a class `Promise` with two constructor parameters: `resolve` (fired when the promise is resolved) and `reject` (fired when the promise is rejected). |
There was a problem hiding this comment.
@nitish24p is this description ok? Do they need to implement the polyfill part (checking windows object to see if Promise is defined)? And do they need to make the promise fully compliant (implementing finally and the other promise static methods)?
clovis1122
commented
Oct 7, 2020
| ### Solution | ||
|
|
||
| ```javascript | ||
| function Promise(callback) { |
There was a problem hiding this comment.
Let me know if this solution is ok. I intentionally avoided modern JS syntax but can reconstruct the solution if needed. Some missing parts are that the then call does not follow returned promises, and the finally implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the markdown to implement a Promise Polyfill. The PR is still not ready, but I wanted to open it to ask some questions.