Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Client faculty filtering and reduced fetches #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Client faculty filtering and reduced fetches #167

wants to merge 2 commits into from

Conversation

heydoyouknowme0
Copy link
Contributor

closes #160

GetPsyched
GetPsyched requested changes Apr 27, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add the requested changes as new commits. Add all fixes relevant to the issue in the first commit and leave the 2nd commit as is.

app/[locale]/faculty-and-staff/client-utils.tsx Show resolved Hide resolved
app/[locale]/faculty-and-staff/page.tsx Show resolved Hide resolved
@GetPsyched
Copy link
Member

GetPsyched commented Apr 27, 2024 •
edited
Loading

Also:
image

@heydoyouknowme0
Copy link
Contributor Author

Currently there's no way to clear query (backspace ig) and departments, should that be added too?

@GetPsyched
Copy link
Member

If that's not possible for the typed query, then yes please add that. For departments we'll have to ask the design team how will it be cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GetPsyched GetPsyched GetPsyched requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert faculty filtering by query to client component
2 participants
@heydoyouknowme0 @GetPsyched