Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of Material UI TextField integration #131

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

steurt
Copy link
Contributor

@steurt steurt commented Jun 5, 2020

I've integrated mui-rte editor in a form I built. I wanted it to have the same style and behaviour as the other Material UI form elements. Preferably also with similar code usage.

Material UI describes how 3rd party libraries can integrate with its TextField component. Which is in itself composed using other input components default available in Material UI. I wrapped MUIRichTextEditor in a custom RichTextField component that is setup according to the Material UI TextField integration.

The RichTextField integrates nicely with the other elements in my form. The style and behaviour are the same and the code usage is very similar and consistent.

I wanted to share this setup so other people can possibly take advantage of this. Therefore I've added an example that uses the custom RichTextField component that integrates nicely with the TextField api.

MUITextFieldIntegration

Tymen Steur and others added 4 commits June 5, 2020 17:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Removed the `defaultValue` prop, since it is already a part of the `TextFieldProps`.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@steurt
Copy link
Contributor Author

steurt commented Nov 8, 2020

@TrejGun can you check this again?

@TrejGun
Copy link

TrejGun commented Nov 10, 2020

LGTM

@steurt
Copy link
Contributor Author

steurt commented Nov 10, 2020

@TrejGun can you approve the PR?

@TrejGun
Copy link

TrejGun commented Nov 10, 2020

sorry did not realize i'm blocking it from being merged

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@steurt
Copy link
Contributor Author

steurt commented Nov 11, 2020

@TrejGun I've had to merge with master again and therefore require another approval. Would you check and approve the PR again please?

@TrejGun
Copy link

TrejGun commented Nov 11, 2020

sure :)

@steurt
Copy link
Contributor Author

steurt commented Nov 11, 2020

@TrejGun what is needed to merge this? The Run Unit Tests isn't running which at least is required to allow merging.

@TrejGun
Copy link

TrejGun commented Nov 11, 2020

I believe you need review of @niuware not mine :)

@steurt
Copy link
Contributor Author

steurt commented Nov 13, 2020

@niuware can you review this as well?

@TrejGun
Copy link

TrejGun commented Nov 18, 2020

Screen Shot 2020-11-18 at 8 59 34 AM

looks like this code works not so well
it removes focus from popover so I can't paste url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants