Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration tests #248

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

tinybeachthor
Copy link
Contributor

Add integration tests to detect regressions for #221, #235.
Run tests in github action.

@tinybeachthor tinybeachthor changed the title test: add integration test test: add integration tests Aug 11, 2022
@DavHau
Copy link
Member

DavHau commented Aug 12, 2022

Wonderful! Could you add a comment to the top of each flake.nix explaining in one or two sentences why the test exists / what it does?

@yusdacra
Copy link
Member

This is great, but doesn't this basically copy all of examples testing code? Maybe instead of copying it all we could parametrize the testing code so we can pass examples dir and integration-tests dir etc.

@tinybeachthor
Copy link
Contributor Author

@DavHau
Added descriptions for the integration tests

@yusdacra
The test runner is not the same, for examples we are running nix check and don't evaluate haskell packages, for the integration tests we want to actually build the default package.
I personally don't mind code duplication in test setups. Unifying and parameterizing the scripts would only subtract from readability.

@DavHau DavHau merged commit 6d4f103 into nix-community:main Aug 18, 2022
@DavHau DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer-of-nix Issues/PRs opened by SoN participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants