Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: code coverage #194

Merged
merged 2 commits into from
Nov 20, 2024
Merged

ci: code coverage #194

merged 2 commits into from
Nov 20, 2024

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Nov 19, 2024

Oops, didn't get the memo about #162

@matijs Even kijken of er ook in mijn approach wat snippets zitten die we willen gebruiken?

Ik kom wel heel erg op het punt dat ik een interne package wil hebben voor een shared config voor bijvoorbeeld jest.

@Robbert Robbert requested a review from matijs November 19, 2024 19:33
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 8:01am

@matijs matijs enabled auto-merge (rebase) November 20, 2024 07:59
@matijs
Copy link
Member

matijs commented Nov 20, 2024

Ik heb collectCoverage eruit gehaald want daar hebben we test:coverage voor. Ik zal er zo een package voor bakken.

@matijs matijs merged commit 56c87d9 into main Nov 20, 2024
7 of 8 checks passed
@matijs matijs deleted the ci/codecov branch November 20, 2024 08:00
@matijs
Copy link
Member

matijs commented Nov 20, 2024

Zie nl-design-system/basis#41 voor een shareable config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants