Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Avatar-component without use of design-tokens #11

Merged
merged 17 commits into from
Jan 3, 2024

Conversation

ryanvvalkenhoef
Copy link
Contributor

No description provided.

packages/components-react/src/Avatar.tsx Outdated Show resolved Hide resolved
packages/components-react/src/Avatar.tsx Outdated Show resolved Hide resolved
packages/components-react/src/Button.tsx Outdated Show resolved Hide resolved
packages/storybook/config/preview.tsx Outdated Show resolved Hide resolved
export const Image: Story = {
args: {
imageSrc: 'https://entertainment.inquirer.net/files/2012/08/beyonce-knowles.jpg',
altText: 'Profielfoto',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zouden de properties korter kunnen en meer in lijn met de DOM APIs?
<Avatar src="some.png" alt="Pretty Woman walking down the street"/>

packages/storybook/src/css-button.stories.tsx Show resolved Hide resolved
packages/storybook/src/avatar/css-avatar.stories.tsx Outdated Show resolved Hide resolved
@ryanvvalkenhoef ryanvvalkenhoef merged commit 896dc1c into main Jan 3, 2024
6 checks passed
@ryanvvalkenhoef ryanvvalkenhoef deleted the ryan-avatar branch January 3, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants