Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch round 2024-04 #60

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Patch round 2024-04 #60

merged 5 commits into from
Apr 24, 2024

Conversation

matijs
Copy link
Member

@matijs matijs commented Apr 12, 2024

Install all patch, minor, and major updates.

Stay on ESLint v8 for now.

Upgrade to Storybook v8.

@matijs matijs requested a review from Robbert April 12, 2024 10:39
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nldesignsystem-nl-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 7:56pm

@Robbert
Copy link
Member

Robbert commented Apr 22, 2024

De view source van de CSS button en van de Web component button is kapot, maar dat was blijkbaar al zo.

@Robbert Robbert self-requested a review April 23, 2024 06:57
Update Storybook to v8. Remove incompatible addons
(@etchteam/storybook-addon-status) and its configuration.

Simplify config:

- Move the decorator to its own .tsx file and rename main.tsx and
  preview.tsx to main.ts and preview.ts respectively
- Add types

Rename *.stories.mdx -> *.mdx as this is now required for Storybook 8.

Remove unused vite.config.ts

Remove unused dependencies.

Remove Storybook deps from .ncurc.major.cjs
@matijs matijs force-pushed the build/patch-round-2024-04 branch from 1db6386 to 54b8971 Compare April 24, 2024 19:55
@matijs matijs merged commit 4dd76f4 into main Apr 24, 2024
8 checks passed
@matijs matijs deleted the build/patch-round-2024-04 branch April 24, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants