Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump eslint-plugin-json from 3.1.0 to 4.0.1 #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build(deps-dev): bump eslint-plugin-json from 3.1.0 to 4.0.1 #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb300c
build(deps-dev): bump eslint-plugin-json from 3.1.0 to 4.0.1
dependabot[bot] Sep 8, 2024
22de453
chore: change eslint settings (schema issue)
hansregeer Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
},
"overrides": [
{
"extends": ["plugin:json/recommended"],
"files": ["*.json"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here seems to be that files is not recognized as a valid top-level property within the overrides block in the .eslintrc.json file. In ESLint, the overrides block can specify configurations based on certain file patterns, but the structure should follow ESLint's schema.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still fails... locally it succeeded after this change..

"files": ["*.json"],
"extends": ["plugin:json/recommended"]
},
{
"extends": [
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"eslint": "8.57.0",
"eslint-config-prettier": "9.1.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-json": "3.1.0",
"eslint-plugin-json": "4.0.1",
"eslint-plugin-mdx": "3.1.5",
"eslint-plugin-react": "7.34.1",
"husky": "9.1.5",
Expand Down
12 changes: 6 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading