remove some allow && do some refactor #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and code quality of the
del-geo-core
module. The key changes involve adding new methods, refactoring existing methods for better readability and performance, and removing unnecessary code.New Methods Added:
del-geo-core/src/mat3_col_major.rs
: Addedtransform_homogeneous
method to theMat3ColMajor
trait and its implementation. [1] [2]Refactoring for Readability and Performance:
del-geo-core/src/obb3.rs
: Refactoredtest_nearest_to_point3
function to use method chaining for better readability.del-geo-core/src/polynomial_root.rs
: Replacednum_traits::clamp
with theclamp
method for better performance and readability.del-geo-core/src/view_projection.rs
: Simplified matrix multiplication in thePerspective
struct's implementation.del-geo-core/src/view_rotation.rs
: RefactoredTrackball
struct's methods to use method chaining and instance methods for better readability. [1] [2]Code Cleanup:
del-geo-core/src/spherical_harmonics.rs
: Removed unnecessaryclippy
lint allowances.Dependency Management:
del-geo-core/src/view_projection.rs
: AddedMat4ColMajor
import.del-geo-core/src/view_rotation.rs
: AddedQuaternion
import.