Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump IREE to 7850ea99eebadf84e91963da12a49236fdd613f5 #924

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

yzhang93
Copy link
Contributor

No description provided.

@newling
Copy link
Contributor

newling commented Nov 22, 2024

The failing test was added in #795

@newling
Copy link
Contributor

newling commented Nov 25, 2024

Probably this commit:

llvm/llvm-project@3ad0148#diff-72ebcdb4d3db4feaffadbb116379626ea14f4383014ef24792e2b6c37765143d

Annoyingly there isn't a single example of using linalg.matmul in any python tests in MLIR upstream.

Makes me wonder if these tests will easy to maintain going forward, or if we should disable this directory for now and reconsider it at a later point.

@yzhang93
Copy link
Contributor Author

I think the pytest are failing because of the change upstream that linalg.matmul is now defined using TableGen ODS instead of Python-based OpDSL. llvm/llvm-project#115319

@makslevental @newling Any suggestions on what action we should take on test_matmul.py?

@yzhang93
Copy link
Contributor Author

Probably this commit:

llvm/llvm-project@3ad0148#diff-72ebcdb4d3db4feaffadbb116379626ea14f4383014ef24792e2b6c37765143d

Annoyingly there isn't a single example of using linalg.matmul in any python tests in MLIR upstream.

Makes me wonder if these tests will easy to maintain going forward, or if we should disable this directory for now and reconsider it at a later point.

Just saw your comment after sending mine :) yeah, I think we should probably want to disable the tests unless @makslevental has a better idea to refactor these tests.

@yzhang93 yzhang93 merged commit 458945b into nod-ai:main Nov 25, 2024
5 checks passed
@yzhang93 yzhang93 deleted the bump_iree_112224 branch January 3, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants