test: run test on Node.js 23 (#543)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
	- Added support for Node.js version 23 in the CI pipeline.

- **Documentation**
- Enhanced documentation for the `urllib` package with new sections,
examples, and detailed explanations of the `request` method and its
options.
	- Expanded `API Doc` and `Response Object` sections for better clarity.
- Included advanced use case examples and updated benchmarks for
performance metrics across Node.js versions.

- **Tests**
- Improved test coverage for the `HttpClient` class, focusing on
connection statistics and client options validation.
- Enhanced error handling and assertions in `writeStream` tests,
reflecting updates for Node.js version 23 and improving robustness.
- Refined error handling logic in `options.compressed` tests, ensuring
accurate decompression error codes.
- Adjusted timeout values in `options.timeout` tests to align with
updated expectations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

.github/workflows/nodejs.yml

@@ -12,6 +12,6 @@ jobs:
     uses: node-modules/github-actions/.github/workflows/node-test.yml@master
     with:
       os: 'ubuntu-latest, macos-latest, windows-latest'
-      version: '18.19.0, 18, 20, 22'
+      version: '18.19.0, 18, 20, 22, 23'
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

README.md

@@ -345,8 +345,6 @@ Node.js v22.3.0
 
 [MIT](LICENSE)
 
-<!-- GITCONTRIBUTOR_START -->
-
 ## Contributors
 
 [![Contributors](https://contrib.rocks/image?repo=node-modules/urllib)](https://github.com/node-modules/urllib/graphs/contributors)

examples/search_github.cjs

@@ -8,6 +8,7 @@ urllib.request('https://api.github.com/legacy/user/search/location:china', {
   timeout: 10000,
 }).then(response => {
   console.log(response);
+  console.log(response.data);
 });
 
 // var https = require('https');

examples/timing.cjs

@@ -16,7 +16,7 @@ async function request(index) {
   }
   const res = await httpClient.request(url + '?index=' + index, {
     // data: { wd: 'nodejs' },
-    dataType: 'json',
+    // dataType: 'json',
   });
   console.log('---------------------------');
   console.log('No#%d: %s, content size: %d, requestUrls: %o, socket: %o, rt: %o',

package.json

@@ -91,12 +91,10 @@
   "exports": {
     ".": {
       "import": {
-        "source": "./src/index.ts",
         "types": "./dist/esm/index.d.ts",
         "default": "./dist/esm/index.js"
       },
       "require": {
-        "source": "./src/index.ts",
         "types": "./dist/commonjs/index.d.ts",
         "default": "./dist/commonjs/index.js"
       }
@@ -108,5 +106,6 @@
     "src"
   ],
   "types": "./dist/commonjs/index.d.ts",
-  "main": "./dist/commonjs/index.js"
+  "main": "./dist/commonjs/index.js",
+  "module": "./dist/esm/index.js"
 }

src/fetch.ts

@@ -163,7 +163,7 @@ export class FetchFactory {
       [symbols.kEnableRequestTiming]: !!(init.timing ?? true),
       [symbols.kRequestTiming]: timing,
       // [symbols.kRequestOriginalOpaque]: originalOpaque,
-    };
+    } as FetchOpaque;
     const reqMeta: RequestMeta = {
       requestId,
       url: request.url,

test/HttpClient.test.ts

@@ -110,7 +110,7 @@ describe('HttpClient.test.ts', () => {
         httpClient.request(_url),
       ]);
       console.log(httpClient.getDispatcherPoolStats());
-      assert.equal(httpClient.getDispatcherPoolStats()['https://registry.npmmirror.com'].connected, 1);
+      assert.equal(httpClient.getDispatcherPoolStats()['https://registry.npmmirror.com'].connected, 4);
       assert(httpClient.getDispatcherPoolStats()[_url.substring(0, _url.length - 1)].connected > 1);
     });
   });

test/options.compressed.test.ts

@@ -3,7 +3,7 @@ import { createWriteStream, createReadStream } from 'node:fs';
 import { describe, it, beforeAll, afterAll, beforeEach, afterEach } from 'vitest';
 import urllib from '../src/index.js';
 import { startServer } from './fixtures/server.js';
-import { readableToString, createTempfile, nodeMajorVersion } from './utils.js';
+import { readableToString, createTempfile } from './utils.js';
 
 describe('options.compressed.test.ts', () => {
   let close: any;
@@ -193,7 +193,7 @@ describe('options.compressed.test.ts', () => {
       // console.error(err);
       assert.equal(err.name, 'UnzipError');
       assert.equal(err.message, 'Decompression failed');
-      if (nodeMajorVersion() >= 20) {
+      if (process.version !== 'v18.19.0') {
         assert.equal(err.code, 'ERR__ERROR_FORMAT_PADDING_1');
       } else {
         assert.equal(err.code, 'ERR_PADDING_1');

test/options.timeout.test.ts

@@ -57,7 +57,7 @@ describe('options.timeout.test.ts', () => {
 
   it('should timeout 500ms throw error', async () => {
     await assert.rejects(async () => {
-      const response = await urllib.request(`${_url}mock-bytes?timeout=1000`, {
+      const response = await urllib.request(`${_url}mock-bytes?timeout=1500`, {
         timeout: [ 400, 500 ],
       });
       console.log(response.status, response.headers, response.data);

test/options.writeStream.test.ts

@@ -117,8 +117,13 @@ describe('options.writeStream.test.ts', () => {
       // only Node.js >= 18 has stream.emitError
       if (err.message !== 'writeStream is destroyed') {
         assert.equal(err.name, 'Error');
-        assert.equal(err.code, 'ENOENT');
-        assert.match(err.message, /no such file or directory/);
+        assert.match(err.code, /^ENOENT|ERR_STREAM_UNABLE_TO_PIPE$/);
+        if (err.code === 'ERR_STREAM_UNABLE_TO_PIPE') {
+          // change to ERR_STREAM_UNABLE_TO_PIPE on Node.js >= 23
+          assert.equal(err.message, 'Cannot pipe to a closed or destroyed stream');
+        } else {
+          assert.match(err.message, /no such file or directory/);
+        }
       }
       return true;
     });