www: log cdn purge calls #2269
Merged
www: log cdn purge calls #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
commented
Apr 7, 2020
| @@ -44,6 +44,7 @@ docker run \ | |||
| -v /home/nodejs/.npm:/npm/ \ | |||
| node:latest \ | |||
| bash -c " \ | |||
| apt-get update && apt-get install -y rsync && \ | |||
There was a problem hiding this comment.
this is a holdover from some website publish debugging we were doing a few months ago, changed on server but not in ansible, I'm unsure if this is necessary but it's there for now!
rvagg
commented
Apr 7, 2020
| @@ -27,6 +27,8 @@ if ! [ -f /tmp/cdnpurge.$site ]; then | |||
| exit 0 | |||
| fi | |||
|
|
|||
| reason="$(cat /tmp/cdnpurge.$site | tr '\n' ' ')" | |||
There was a problem hiding this comment.
Previously this file was a zero-length signal file, now it should contain a "reason", but it may also contain multiple reasons if more than one request was made before we check it, hence the flattening of multiple lines into one. We use this in the log, below.
AshCripps
approved these changes
Apr 7, 2020
rvagg
force-pushed
the
rvagg/purge-scripts-safer
branch
from
50ade9c to
eb6e0b2
Compare
richardlau
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2264
We don't have logs of our calls to Cloudflare's cache purge API calls we make when we promote new /download/ assets or publish new website content, so this is adding such logging. Along the way, I think I've found one possible "bug" that may provide a partial explanation to our outage problems, but I'll explain that in #2249
Additional comments inline.