Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use astral-sh/ruff-action@v3 to run the Python linter #3114

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 31, 2024

https://github.com/astral-sh/ruff-action

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@cclauss cclauss changed the title Use pipx instead of pip to install the ruff linter Use astral-sh/ruff-action@v3 to run the Python linter Dec 31, 2024
@cclauss cclauss changed the title Use astral-sh/ruff-action@v3 to run the Python linter chore: Use astral-sh/ruff-action@v3 to run the Python linter Dec 31, 2024
@cclauss cclauss mentioned this pull request Dec 31, 2024
4 tasks
@cclauss cclauss requested review from Trott and legendecas January 2, 2025 12:28
@legendecas
Copy link
Member

seems like macos-13 failed for network issues. restarting

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I know almost nothing about astral-sh specifically and the Python ecosystem in general and will defer to others, unless we're having trouble getting more knowledgeable reviewers.

@Trott
Copy link
Member

Trott commented Jan 2, 2025

Pinging widely to get some reviews: @nodejs/python @nodejs/node-gyp @nodejs/addon-api @nodejs/build

@legendecas
Copy link
Member

AFAICT, ruff is maintained by astral-sh.

@cclauss cclauss merged commit 94448fc into main Jan 2, 2025
34 checks passed
@cclauss cclauss deleted the pipx-install-ruff branch January 2, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants