Test on GitHub Actions windows-2025 image
#3116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
commented
Jan 6, 2025
cclauss
force-pushed
the
GitHub-Actions-windows-2025
branch
from
a40c064 to
aa2aa3e
Compare
cclauss
force-pushed
the
GitHub-Actions-windows-2025
branch
from
aa2aa3e to
dce3aef
Compare
cclauss
changed the title
cclauss
changed the title
windows-2025 image
cclauss
added a commit
to cclauss/gyp-next
that referenced
this pull request
Jan 7, 2025
legendecas
reviewed
Jan 7, 2025
| @@ -456,6 +457,8 @@ class VisualStudioFinder { | |||
| return 'v142' | |||
| } else if (versionYear === 2022) { | |||
| return 'v143' | |||
| } else if (versionYear === 2025) { | |||
| return 'v143' // Fix this when Visual Studio 2025 ships | |||
There was a problem hiding this comment.
Is these VS 2025 changes required now? Shall we add these when VS 2025 is actually released?
There was a problem hiding this comment.
These tests will fail on Windows 2025 without these mods because Windows 2025 currently ships with Visual Studio 2022.
That is probably a question for @StefanStojanovic. I am not a Windows user but if Windows 2025 is available on GitHub Actions, it will not be long before new issues are opened about using it. The great news is that it seems to work out-of-the box and in some tests is quite a bit faster. The only incompatibility appears in our integration tests because we are still many months away from having a Visual Studio 2025.
cclauss
added a commit
to nodejs/gyp-next
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Three lines will need to be changed when Visual Studio 2025 ships near the end of 2025.
.github/workflows/visual-studio.yml-- One line.lib/find-visualstudio.js-- Two lines.https://learn.microsoft.com/en-us/windows-server/get-started/windows-server-release-info
https://learn.microsoft.com/en-us/windows-server/get-started/whats-new-windows-server-2025
The normal GitHub Actions tests pass on Windows Server 2025 butvisual-studio/visual-studio (windows-2025, 2025)fails with:Windows 2025 currently ships with Visual Studio 2022.
vswhere -latest -property installationPathChecklist
npm install && npm run lint && npm testpassesDescription of change