refactor: throw error and add test for it

nodejs · Dec 18, 2024 · aa465fb · aa465fb
1 parent 46c6d06
commit aa465fb
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/interceptor/dns.js b/lib/interceptor/dns.js
@@ -339,7 +339,7 @@ module.exports = interceptorOpts => {
   return (dispatch, opts) => {
     return function dnsInterceptor (origDispatchOpts, handler) {
       if (!origDispatchOpts.origin) {
-        return handler.onResponseError(null, new InvalidArgumentError('Origin Missing'))
+        throw new InvalidArgumentError('Origin missing')
       }
 
       const origin = origDispatchOpts.origin.constructor === URL

diff --git a/test/interceptors/dns.js b/test/interceptors/dns.js
@@ -29,6 +29,25 @@ test('Should validate options', t => {
   t.throws(() => dns({ pick: [] }), { code: 'UND_ERR_INVALID_ARG' })
 })
 
+test('Should throw when origin is missing', async t => {
+  t = tspl(t, { plan: 1 })
+  const client = new Agent().compose([
+    dns()
+  ])
+
+  after(async () => {
+    await client.close()
+  })
+
+  let error
+  try {
+    await client.request({})
+  } catch (err) {
+    error = err
+  }
+  t.equal(error.code, 'UND_ERR_INVALID_ARG')
+})
+
 test('Should automatically resolve IPs (dual stack)', async t => {
   t = tspl(t, { plan: 8 })