Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Companies optional url #141

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Great Companies optional url #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/components/Companies.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,24 @@
:key="company.name"
class="logo px-3 col-6 col-md-4 col-lg-2 me-0 px-md-5 px-lg-4"
>
<a class="logo-link" :href="company.url" target="_blank">
<a
v-if="company.url"
class="logo-link"
:href="company.url"
target="_blank"
>
<img
class="grayscale img-fluid svg-ie-fix"
:src="getAsset(`@/images/${company.logo}`)"
:title="company.name"
/>
</a>
<img
v-else
class="grayscale img-fluid svg-ie-fix"
:src="getAsset(`@/images/${company.logo}`)"
:title="company.name"
/>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/types/IProject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export interface IProject {
}
export interface ICompany {
name: string;
url: string;
url?: string;
logo: string;
}
export interface ISkillGroup {
Expand Down
Loading