fix: Minor issues found in PR revision

nomasystems · Jan 11, 2024 · 5a7d69b · 5a7d69b
1 parent 26fddee
commit 5a7d69b
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,7 +7,6 @@ on:
     branches: [main]
 
 env:
-  OTP-VERSION: 26.2.1
   REBAR3-VERSION: 3.22.1
 
 jobs:

diff --git a/rebar.config b/rebar.config
@@ -14,8 +14,8 @@
         dialyzer
     ]},
     {test, [
-        {ct, "--sname nbully --spec test/conf/test.spec --cover --readable true"},
-        {cover, "-m 100"}
+        {ct, "--sname nbully --spec test/conf/test.spec --cover --readable true -v"},
+        {cover, "-m 95"}
     ]}
 ]}.
 

diff --git a/test/conf/cover.conf b/test/conf/cover.conf
diff --git a/test/conf/test.cfg b/test/conf/test.cfg
@@ -1,2 +1 @@
-%%% -*- mode:erlang -*-
 {apps, [sasl, nbully]}.
diff --git a/test/nbully_SUITE.erl b/test/nbully_SUITE.erl
@@ -79,7 +79,7 @@ api_neg(_Conf) ->
     Peers = start_peers(9),
     {ok, Subscriber} = subscriber_srv:start(),
     {Leader, _} = lists:max(Peers),
-    rpc:call(Leader, application, stop, [nbully]),
+    ok = rpc:call(Leader, application, stop, [nbully]),
 
     timer:sleep(500),
     NewLeader = nbully:leader(),

diff --git a/test/nbully_wrk_SUITE.erl b/test/nbully_wrk_SUITE.erl
@@ -20,7 +20,7 @@
 %%% EXTERNAL EXPORTS
 %%%-----------------------------------------------------------------------------
 all() ->
-    [sys_calls].
+    [sys_calls, undefined_if_not_started].
 
 %%%-----------------------------------------------------------------------------
 %%% TEST CASES
@@ -35,3 +35,9 @@ sys_calls(_Conf) ->
     ok = sys:resume(Pid),
     unlink(Pid),
     ok = nbully_wrk:stop().
+
+undefined_if_not_started() ->
+    [{userdata, [{doc, "Tests not crashing if called with a non-started worker."}]}].
+
+undefined_if_not_started(_Conf) ->
+    undefined = nbully_wrk:leader().
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,6 @@ on: @@
         branches: [main]
     env:
-      OTP-VERSION: 26.2.1
       REBAR3-VERSION: 3.22.1
     jobs:
@@ Expand Down @@