Bundle cjs and esm #211
Closed
Bundle cjs and esm #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtsquiggs
force-pushed
the
hybrid-bundling-esm-cjs
branch
8 times, most recently
from
f60c06e to
40d7a68
Compare
sgtsquiggs
force-pushed
the
hybrid-bundling-esm-cjs
branch
from
735433c to
113acaf
Compare
|
This did not work as intended, closing. |
|
Appreciate the attempt - it's harder than it should be to get things to coexist in a reasonable way. The ecosystem gets pretty wrecked by these splits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
Changes proposed in this pull request:
Bundle both cjs and esm making a few changes as possible.
Reviewers should focus on:
Confirming the new bundle works in both cjs and esm projects.