Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for pass through of DescribedType body in service bus policy, for SAS token sending as AMQPval #356

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tony-gutierrez
Copy link

@tony-gutierrez tony-gutierrez commented Feb 10, 2018

When using SAS tokens with an Azure Service Bus, it is necessary to
send the token to $cbs as an AQMPval type body. The current policy
encoder prevents this.

Add example for sas token sending to service bus.


This change is Reviewable

…or SAS token sending as AMQPval

When using SAS tokens with an Azure Service Bus, it is necessary to
send the token to $cbs as an AQMPval type body. The current policy
encoder prevents this.

Add example for sas token sending to service bus

Remove settings

remove packagelock
added semicolon
@tony-gutierrez
Copy link
Author

Just realized the pass through may not be needed as you could just do:
client.createSender('$cbs', {'encoder':null})

Let me know if the pass through of DescribedType in the policy is not desired and ill remove that change and just update the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant