Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up CS INVALIDATED event #6

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Hook up CS INVALIDATED event #6

merged 1 commit into from
Oct 3, 2024

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Oct 3, 2024 •
edited
Loading

The CS INVALIDATED event had previously been implemented here: google/santa#1210

However it was never subscribed to. This PR adds the subscriptions and hooks up the appropriate metrics.

@mlw mlw requested a review from a team as a code owner October 3, 2024 22:37
@pmarkowsky pmarkowsky added comp/santad Issues or PRs related to the daemon telemetry Issues / PRs that change the telemetry output recorder Issues or PRs related to the recorder client labels Oct 3, 2024
pmarkowsky
pmarkowsky approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw added this to the 2024.10 milestone Oct 3, 2024
@mlw mlw merged commit 488e392 into northpolesec:main Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
comp/santad Issues or PRs related to the daemon recorder Issues or PRs related to the recorder client telemetry Issues / PRs that change the telemetry output
Projects
None yet
Milestone
2024.10
Development

Successfully merging this pull request may close these issues.
2 participants
@mlw @pmarkowsky