Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing quote marks for hrefs when template code is used. #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tstoeter
Copy link
Contributor

No description provided.

Errors where reported from linter `tidy -e` and fixed using sed
```
sed -i 's/href={{\(.*\)}}/href="{{\1}}"/g' `grep -l -R "href={{" *`
```
@not-matthias
Copy link
Owner

Hey, had to revert the other commit due to conflicts with the search PR. Is there any benefit to adding the quotes? The HTML is rendered correctly with and without them.

@tstoeter
Copy link
Contributor Author

The HTML linter tidy reported the missing quote marks as errors, i.e. it is not 100% valid HTM code, although rendered correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants