-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create production deploy yml #219
base: main
Are you sure you want to change the base?
Conversation
This commit will simply copy the staging-deploy.tmpl.yaml file to production-deploy.tmpl.yaml. In the next commit we can more easily track the changes.
This commit will bring over values from the current production-deploy.yaml file on pals production.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
15385149 | Triggered | Generic Database Assignment | 2fd632d | ops/production-deploy.tmpl.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
embargoRelease: | ||
enabled: false | ||
leaseRelease: | ||
enabled: false | ||
|
||
nameOverride: pals | ||
fcrepo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we weren't sure what to do about this fcrepo:
section
https://github.com/notch8/palni-palci/blob/main/ops/production-deploy.tmpl.yaml#L384-L398
Also, should we update to hykucommons.org wherever we're referencing pals-knapsack.notch8...? Or wait to update after the ingress switch?
|
||
resources: | ||
limits: | ||
memory: "8Gi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orangewolf should the limits match what's currently in prod?
Refs #212
2fd632d
This commit will simply copy the staging-deploy.tmpl.yaml file to
production-deploy.tmpl.yaml. In the next commit we can more easily
track the changes.
Update production-deploy.tmpl.yaml
5bf7447
This commit will bring over values from the current
production-deploy.yaml file on pals production.