Rename MobilePhoneContact to PhoneContact (tel:)

notificohq · Dec 17, 2024 · c090c5f · c090c5f
1 parent b5a7aa2
commit c090c5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/notifico-core/src/contact.rs b/notifico-core/src/contact.rs
@@ -33,11 +33,11 @@ pub trait TypedContact: TryFrom<RawContact, Error = EngineError> {
 }
 
 #[derive(Serialize, Deserialize, Clone)]
-pub struct MobilePhoneContact {
+pub struct PhoneContact {
     pub number: String,
 }
 
-impl TryFrom<RawContact> for MobilePhoneContact {
+impl TryFrom<RawContact> for PhoneContact {
     type Error = EngineError;
 
     fn try_from(value: RawContact) -> Result<Self, Self::Error> {
@@ -47,11 +47,11 @@ impl TryFrom<RawContact> for MobilePhoneContact {
     }
 }
 
-impl TypedContact for MobilePhoneContact {
-    const CONTACT_TYPE: &'static str = "mobile_phone";
+impl TypedContact for PhoneContact {
+    const CONTACT_TYPE: &'static str = "tel";
 }
 
-impl MobilePhoneContact {
+impl PhoneContact {
     pub fn msisdn(&self) -> &str {
         self.number.strip_prefix("+").unwrap_or(&self.number)
     }

diff --git a/transports/notifico-smpp/src/lib.rs b/transports/notifico-smpp/src/lib.rs
@@ -6,7 +6,7 @@ use crate::step::{Step, STEPS};
 use async_trait::async_trait;
 use futures_util::sink::SinkExt;
 use futures_util::StreamExt;
-use notifico_core::contact::MobilePhoneContact;
+use notifico_core::contact::PhoneContact;
 use notifico_core::credentials::CredentialStorage;
 use notifico_core::engine::{EnginePlugin, PipelineContext, StepOutput};
 use notifico_core::error::EngineError;
@@ -102,7 +102,7 @@ impl EnginePlugin for SmppPlugin {
                     }
                 }
 
-                let contact: Vec<MobilePhoneContact> = context.get_recipient()?.get_contacts();
+                let contact: Vec<PhoneContact> = context.get_recipient()?.get_contacts();
 
                 for contact in contact {
                     for message in context.messages.iter().cloned() {

diff --git a/transports/notifico-whatsapp/src/lib.rs b/transports/notifico-whatsapp/src/lib.rs
@@ -1,7 +1,7 @@
 use crate::cloudapi::{MessageType, MessagingProduct};
 use crate::credentials::WhatsAppCredentials;
 use async_trait::async_trait;
-use notifico_core::contact::{MobilePhoneContact, RawContact};
+use notifico_core::contact::{PhoneContact, RawContact};
 use notifico_core::credentials::RawCredential;
 use notifico_core::engine::{Message, PipelineContext};
 use notifico_core::simpletransport::SimpleTransport;
@@ -32,7 +32,7 @@ impl SimpleTransport for WabaTransport {
         _context: &mut PipelineContext,
     ) -> Result<(), EngineError> {
         let credential: WhatsAppCredentials = credential.try_into()?;
-        let contact: MobilePhoneContact = contact.try_into()?;
+        let contact: PhoneContact = contact.try_into()?;
         let message: WhatsAppContent = message.content.try_into()?;
 
         let url = format!(