Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Gov/Fellowship selectors #2741

Merged
merged 12 commits into from
Nov 29, 2024
Merged

Feat: Gov/Fellowship selectors #2741

merged 12 commits into from
Nov 29, 2024

Conversation

tuul-wq
Copy link
Contributor

@tuul-wq tuul-wq commented Nov 27, 2024

  • Selector for Gov
  • Selector for Fellowship
  • Simplified filter models for Gov and Fellowship
  • Removed unnecessary constants
  • Switched from networkSelectorModel.$governanceChain to networkSelectorModel.$governanceChainId where possible
  • Turned api?: ApiPromise into api: ApiPromise | null for Fee components

part of #2589

@tuul-wq tuul-wq self-assigned this Nov 27, 2024
@tuul-wq tuul-wq changed the base branch from dev to feat/select_currency November 27, 2024 12:09
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Jest Unit tests results

Generic badge

Duration: 48.915 seconds
Start: 2024-11-29 12:11:36.516 UTC
Finish: 2024-11-29 12:12:25.431 UTC
Duration: 48.915 seconds
Outcome: Passed | Total Tests: 758 | Passed: 757 | Failed: 0
Total Test Suites: 158
Total Tests: 758
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 157
Passed Tests: 757
Pending Test Suites: 1
Pending Tests: 1

Base automatically changed from feat/select_currency to dev November 28, 2024 08:09
# Conflicts:
#	src/renderer/entities/transaction/ui/QrCode/QrReader/QrReaderWrapper.tsx
#	src/renderer/features/currency/CurrencyForm/ui/CurrencyForm.tsx
#	src/renderer/features/wallets/DerivationsAddressModal/ui/DdKeyQrReader.tsx
#	src/renderer/shared/ui-entities/Address/Address.tsx
#	src/renderer/shared/ui-kit/Select/Select.tsx
@tuul-wq tuul-wq requested a review from johnthecat November 28, 2024 13:30
# Conflicts:
#	src/renderer/pages/Governance/ui/Governance.tsx
@tuul-wq tuul-wq merged commit 7f3fe07 into dev Nov 29, 2024
3 checks passed
@tuul-wq tuul-wq deleted the feat/gov_selectors branch November 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants