Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🚀 Feature — Add Web PushAPI support as Push Provider #3385

Open
wants to merge 20 commits into
base: next
Choose a base branch
from
Open

feat: 🚀 Feature — Add Web PushAPI support as Push Provider #3385

wants to merge 20 commits into from

Conversation

johnmarksilly
Copy link

@johnmarksilly johnmarksilly commented May 10, 2023 •
edited
Loading

What change does this PR introduce?

Add a new push provider to support the web PushAPI standard

Why was this change needed?

Support for alternative push method for browsers when external vendors aren't used.

Closes #3459

Other information (Screenshots)

N/A

@johnmarksilly johnmarksilly marked this pull request as ready for review May 18, 2023 21:07
@johnmarksilly johnmarksilly changed the title feat: Add Web PushAPI support as Push Provider feat: 🚀 Feature — Add Web PushAPI support as Push Provider May 18, 2023
djabarovgeorge
djabarovgeorge reviewed May 21, 2023
View reviewed changes
Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job adding a new provider, I left a couple of questions regarding topics I was not sure about.

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Jun 28, 2023
@inveve
Copy link

inveve commented Jul 7, 2023

Any movement on this @johnmarksilly

@github-actions github-actions bot removed the stale Pull Request that needs to be reviewed label Jul 7, 2023
@jainpawan21
Copy link
Member

@johnmarksilly
Please look into merge conflcts

@johnmarksilly
Copy link
Author

@inveve @jainpawan21 @djabarovgeorge See conflict resolutions.

@djabarovgeorge If you have strong opinions about the private/public key credentials let me know and I'll update, but IMO I believe that these will be useful to other devs and are more clear than using other properties. I understand this is hidden from end-users, but devs may find it useful.

@johnmarksilly
Copy link
Author

@jainpawan21 Is this ready for merge?

jainpawan21
jainpawan21 requested changes Jul 13, 2023
View reviewed changes
@inveve
Copy link

inveve commented Jul 25, 2023

Any update @jainpawan21

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Aug 8, 2023
@jainpawan21
Copy link
Member

@djabarovgeorge WDYT what should we do with this PR as there are lot of merge conflicts due to inactivity.

@github-actions github-actions bot removed the stale Pull Request that needs to be reviewed label Dec 19, 2023
@johnmarksilly
Copy link
Author

I can go through and resolve the conflicts tomorrow. Every time I get it ready though, it gets forgotten!

@github-actions github-actions bot added stale Pull Request that needs to be reviewed and removed stale Pull Request that needs to be reviewed labels Jan 5, 2024
@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Jan 19, 2024
@bart-sofomo
Copy link

Wondering if this will ever get merged 🤔

@github-actions github-actions bot removed the stale Pull Request that needs to be reviewed label Mar 11, 2024
@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Mar 25, 2024
@johnmarksilly johnmarksilly requested a review from a team May 14, 2024 10:44
@github-actions github-actions bot removed the stale Pull Request that needs to be reviewed label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsoderberg davidsoderberg davidsoderberg left review comments

@djabarovgeorge djabarovgeorge Awaiting requested review from djabarovgeorge

@jainpawan21 jainpawan21 Awaiting requested review from jainpawan21

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community documentation Improvements or additions to documentation @novu/api @novu/dal @novu/shared @novu/web providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Web Push-API as a Push Provider for those that only build web apps
6 participants
@johnmarksilly @inveve @jainpawan21 @bart-sofomo @davidsoderberg @djabarovgeorge