fix(api-service): Workflow editor improvements #7682
+81
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
changed the title
LetItRock
reviewed
Feb 7, 2025
Comment on lines
127
to
133
| if (variables.subscriber.isOnline) { | ||
| toSchema.properties!.avatar = { type: 'boolean', default: true }; | ||
| } | ||
|
|
||
| if (variables.subscriber.isLastOnline) { | ||
| toSchema.properties!.avatar = { type: 'string', format: 'date-time', default: new Date().toISOString() }; | ||
| } |
There was a problem hiding this comment.
something is odd with these two, we set the avatar property...
despite that, why do we want to allow setting these two values in the form? they are controlled by WS service
There was a problem hiding this comment.
Agree, we shouldn't allow setting the online fields in the to schema.
WS controls these.
I am working on it now, and will remove it
There was a problem hiding this comment.
This is about the test data during preview. We need to give users the ability to test these values especially if they use them in Show conditions.
apps/api/src/app/workflows-v2/usecases/build-test-data/build-workflow-test-data.usecase.ts
Outdated
Show resolved
Hide resolved
Return all subscriber fields as the test data.to field based on the variables used in the workflow and the steps that the workflow includes. That is, an SMS step requires a phone, an Email step an email and any other field should be present in the To test data object if it's used as a variable in the content of the workflow steps.
SokratisVidros
force-pushed
the
workflow_editor_improvements
branch
from
162e66c to
20e480d
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
@novu/client
@novu/headless
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This PR ensures that all the used subscriber fields in a workflow are rendered in the Trigger page in the "Send to" section
Screenshots