Redo enum label addition

To better handling reordering scenarios. Fixes #3424
npgsql · Dec 28, 2024 · 614dcd7 · 614dcd7
1 parent 238d384
commit 614dcd7
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 7 deletions.
diff --git a/src/EFCore.PG/Migrations/NpgsqlMigrationsSqlGenerator.cs b/src/EFCore.PG/Migrations/NpgsqlMigrationsSqlGenerator.cs
@@ -1266,18 +1266,34 @@ protected virtual void GenerateEnumStatements(AlterDatabaseOperation operation,
                     + "https://www.postgresql.org/docs/current/sql-altertype.html)");
             }
 
-            for (var (newPos, oldPos) = (0, 0); newPos < newLabels.Count; newPos++)
+            for (var newPos = 0; newPos < newLabels.Count; newPos++)
             {
                 var newLabel = newLabels[newPos];
-                var oldLabel = oldPos < oldLabels.Count ? oldLabels[oldPos] : null;
-
-                if (newLabel == oldLabel)
+                if (oldLabels.Contains(newLabel))
                 {
-                    oldPos++;
                     continue;
                 }
 
-                GenerateAddEnumLabel(newEnum, newLabel, oldLabel, model, builder);
+                // We add the new label just after the last one we have in the new labels definition (when the last one is new, it will have
+                // just been added).
+                // If the new label happens to be the first one, add it before the first old label. Otherwise, if there are no old labels,
+                // just append the label (no before/after).
+                if (newPos == newLabels.Count - 1)
+                {
+                    GenerateAddEnumLabel(newEnum, newLabel, beforeLabel: null, afterLabel: null, model, builder);
+                }
+                else if (newPos > 0)
+                {
+                    GenerateAddEnumLabel(newEnum, newLabel, beforeLabel: null, afterLabel: newLabels[newPos - 1], model, builder);
+                }
+                else if (oldLabels.Count > 0)
+                {
+                    GenerateAddEnumLabel(newEnum, newLabel, beforeLabel: oldLabels[0], afterLabel: null, model, builder);
+                }
+                else
+                {
+                    GenerateAddEnumLabel(newEnum, newLabel, beforeLabel: null, afterLabel: null, model, builder);
+                }
             }
         }
     }
@@ -1328,9 +1344,15 @@ protected virtual void GenerateAddEnumLabel(
         PostgresEnum enumType,
         string addedLabel,
         string? beforeLabel,
+        string? afterLabel,
         IModel? model,
         MigrationCommandListBuilder builder)
     {
+        if (beforeLabel is not null && afterLabel is not null)
+        {
+            throw new UnreachableException("Both beforeLabel and afterLabel can't be specified");
+        }
+
         var schema = enumType.Schema ?? model?.GetDefaultSchema();
 
         builder
@@ -1345,6 +1367,12 @@ protected virtual void GenerateAddEnumLabel(
                 .Append(" BEFORE ")
                 .Append(_stringTypeMapping.GenerateSqlLiteral(beforeLabel));
         }
+        else if (afterLabel is not null)
+        {
+            builder
+                .Append(" AFTER ")
+                .Append(_stringTypeMapping.GenerateSqlLiteral(afterLabel));
+        }
 
         builder.AppendLine(";");
 

diff --git a/test/EFCore.PG.FunctionalTests/Migrations/MigrationsNpgsqlTest.cs b/test/EFCore.PG.FunctionalTests/Migrations/MigrationsNpgsqlTest.cs
@@ -2892,7 +2892,25 @@ await Test(
                     l => Assert.Equal("Sad", l));
             });
 
-        AssertSql("""ALTER TYPE "Mood" ADD VALUE 'Angry' BEFORE 'Sad';""");
+        AssertSql("""ALTER TYPE "Mood" ADD VALUE 'Angry' AFTER 'Happy';""");
+    }
+
+    [Fact]
+    public virtual async Task Alter_enum_change_label_ordering_does_nothing()
+    {
+        await Test(
+            builder => builder.HasPostgresEnum("Mood", ["Happy", "Sad"]),
+            builder => builder.HasPostgresEnum("Mood", ["Sad", "Happy"]),
+            model =>
+            {
+                var moodEnum = Assert.Single(model.GetPostgresEnums());
+                Assert.Collection(
+                    moodEnum.Labels,
+                    l => Assert.Equal("Happy", l),
+                    l => Assert.Equal("Sad", l));
+            });
+
+        AssertSql();
     }
 
     [Fact]