Handle Nullable<JsonElement> #3008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranma42
reviewed
Dec 5, 2023
src/EFCore.PG/Metadata/Conventions/NpgsqlJsonElementHackConvention.cs
Outdated
Show resolved
Hide resolved
taspeotis
commented
Dec 5, 2023
src/EFCore.PG/Metadata/Conventions/NpgsqlJsonElementHackConvention.cs
Outdated
Show resolved
Hide resolved
taspeotis
force-pushed
the
handle-nullable-jsonelement
branch
from
357a033 to
2061ee9
Compare
|
IIUC #3353 fixes the same issue (and has been merged) |
|
Thanks @ranma42! Will go ahead and close this, sorry that I didn't take a look at this before @taspeotis. |
|
No need to apologise, you do a good job maintaining this library and EF Core. Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wild stab at fixing #2977
Not sure where to put a test for it? FunctionalTests presumably.