fix: issue-5850 - Settle override conflicts between edges and propagate changes #8089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlonNavon 🎉 🕺 |
|
Thank you @owlstronaut! |
|
@jdalton Yep, working on it! I'm brand new to the team/space, so I'm just starting to learn all about this. Happy to accept any help and direction 😄 Going will be slow 😆 |
owlstronaut
commented
Feb 11, 2025
Comment on lines
+97
to
+98
| // rawSpec can be undefined, so we need to use the fallback value of spec if it is. | ||
| let spec = npa(`${edge.name}@${edge.rawSpec || edge.spec}`) |
There was a problem hiding this comment.
I'm making an assumption here that we can fallback
owlstronaut
commented
Feb 20, 2025
…D' for edge override set inconsistencies
owlstronaut
commented
Feb 20, 2025
| @@ -2932,7 +3018,7 @@ t.test('overrides', (t) => { | |||
| ], | |||
| }) | |||
|
|
|||
| t.equal(original.canReplaceWith(badReplacement), false, 'different overrides fails') | |||
| t.equal(original.canReplaceWith(equivalentReplacement), true, 'different overrides passes') | |||
There was a problem hiding this comment.
behavior change, equivalent can now override
|
@jdalton I'm feeling pretty good about this. Any chance you guys have some capacity to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to help get #7025 over the line. The community member did a great job the fixes in - this'll be an attempt to get it over the line
References
Related:
#7025 #5850