Upmerge 2024.12.20 #8457
Annotations
19 errors and 5 warnings
check-warns:
BinaryFiles.txt#L1
No binary files allowed.
Binary file not allowed: samples/net/sockets/http_server/src/certs/ca.der
Binary file not allowed: samples/net/sockets/http_server/src/certs/ca_cert.der
Binary file not allowed: samples/net/sockets/http_server/src/certs/server_cert.der
Binary file not allowed: samples/net/sockets/http_server/src/certs/server_privkey.der
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
-:8907: WARNING:BRACES: braces {} are required around if/while/for/else
#8907: FILE: arch/xtensa/core/elf.c:48:
+ if (ext->sect_hdrs[sh_ndx].sh_addr <= *got_entry &&
+ *got_entry <
-:118385: WARNING:BRACES: braces {} are required around if/while/for/else
#118385: FILE: drivers/clock_control/clock_control_npcm.c:346:
+ while (sys_test_bit(priv->hfcgctrl, NPCM_HFCGCTRL_CLK_CHNG))
+ ;
-:122280: WARNING:BRACES: braces {} are required around if/while/for/else
#122280: FILE: drivers/counter/counter_renesas_ra_agt.c:76:
+ while (!(reg->AGTCR & BIT(R_AGTX0_AGT16_CTRL_AGTCR_TCSTF_Pos)) && likely(--timeout))
+ ;
-:122293: WARNING:BRACES: braces {} are required around if/while/for/else
#122293: FILE: drivers/counter/counter_renesas_ra_agt.c:89:
+ while ((reg->AGTCR & BIT(R_AGTX0_AGT16_CTRL_AGTCR_TCSTF_Pos)) && likely(--timeout))
+ ;
-:130101: WARNING:BRACES: braces {} are required around if/while/for/else
#130101: FILE: drivers/dma/dma_mcux_edma.c:640:
+ if (pre_idx >= CONFIG_DMA_TCD_QUEUE_SIZE)
+ pre_idx = CONFIG_DMA_TCD_QUEUE_SIZE - 1;
-:131040: WARNING:BRACES: braces {} are required around if/while/for/else
#131040: FILE: drivers/dma/dma_nxp_sdma.c:79:
+ if (bytes > chan_data->stat.pending_length)
+ return -EINVAL;
-:131046: WARNING:BRACES: braces {} must be used on all arms of this statement
#131046: FILE: drivers/dma/dma_nxp_sdma.c:85:
+ if (chan_data->stat.read_position > chan_data->stat.write_position)
[...]
+ else
[...]
-:131060: WARNING:BRACES: braces {} are required around if/while/for/else
#131060: FILE: drivers/dma/dma_nxp_sdma.c:99:
+ if (bytes > chan_data->stat.free)
+ return -EINVAL;
-:131066: WARNING:BRACES: braces {} must be used on all arms of this statement
#131066: FILE: drivers/dma/dma_nxp_sdma.c:105:
+ if (chan_data->stat.write_position > chan_data->stat.read_position)
[...]
+ else
[...]
-:131098: WARNING:BRACES: braces {} are required around if/while/for/else
#131098: FILE: drivers/dma/dma_nxp_sdma.c:137:
+ if (chan_data->cb)
+ chan_data->cb(chan_data->dev, chan_data->arg, i, DMA_STATUS_BLOCK);
-:131342: WARNING:BRACES: braces {} are required around if/while/for/else
#131342: FILE: drivers/dma/dma_nxp_sdma.c:381:
+ if (!size)
+ return 0;
-:131345: WARNING:BRACES: braces {} must be used on all arms of this statement
#131345: FILE: drivers/dma/dma_nxp_sdma.c:384:
+ if (chan_data->direction == MEMORY_TO_PERIPHERAL)
[...]
+ else
[...]
-:131377: WARNING:BRACES: braces {} are required around if/while/for/else
#131377: FILE: drivers/dma/dma_nxp_sdma.c:416:
+ if (chan_id == 0)
+ return false;
-:131380: WARNING:BRACES: braces {} are required around if/while/for/else
#131380: FILE: drivers/dma/dma_nxp_sdma.c:419:
+ if (chan_id >= FSL_FEATURE_SDMA_MODULE_CHANNEL)
+ return false;
-:145122: WARNING:BRACES: braces {} are required around if/while/for/else
#145122: FILE: drivers/flash/flash_stm32h7x.c:267:
+ while ((FLASH_STM32_REGS(dev)->SR1 & FLASH_SR_QW) ||
+ (FLASH_STM32_REGS(dev)->SR2 & FLASH_SR_QW))
#else
while (FLASH_STM32_REGS(dev)->SR1 & FLASH_SR_QW)
#endif
-:152075: WARNING:BRACES: braces {} are required around if/while/for/else
#152075: FILE: drivers/gpio/gpio_max149x6.h:16:
+ if ((bit1) & (bit2)) \
+ LOG_ERR("[%s] %d", #bit1, bit1)
+#define PRINT_ERR(bit) \
+ if (bit) \
+ LOG_ERR("[DIAG] [%s] %d\n", #bit, bit)
+#define PRINT_INF(bit) LOG_INFO("[%s] %d\n", #bit, bit)
-:152078: WARNING:BRACES: braces {} are required around if/while/for/else
#152078: FILE: drivers/gpio/gpio_max149x6.h:19:
+ if (bit) \
+ LOG_ERR("[DIAG] [%s] %d\n", #bit, bit)
+#define PRINT_INF(bit) LOG_INFO("[%s] %d\n", #bit, bit)
+#define LOG_DIAG(...) Z_LOG(LOG_LEVEL_ERR, __VA_ARGS__)
-
|
check-warns:
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:2: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:5: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:10: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:11: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:12: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:13: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:14: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:15: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:16: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:17: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:18: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:19: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:20: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:21: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:22: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:23: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:24: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:25: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:26: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:27: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:28: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:29: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:30: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:33: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:34: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:35: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:36: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:37: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:42: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:43: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:44: trailing whitespace.
bb06d9793f912b464ba7cc766d9b4ef36f1f05cf: tests/bluetooth/qualification/ICS_Zephyr_
|
check-warns:
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
e8eae937d457938b7a151894808c0d7391ae640c: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
0c6ac70896afbd36ad6be2f8c599ce92b22a82c0: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
13c380836a4b0503fcf36ede64ce6153e4a9c106: author email (F. Ramu <[email protected]>) needs to match one of the signed-off-by entries.
5aad77e3d669707cb543377c543f848a1165a020: author email (Francois RAMU <[email protected]>) needs to match one of the signed-off-by entries.
b0ba5773dbb22d7a6d726b99585599dbc2aa830c: author email (Stine Akredalen <[email protected]>) needs to match one of the signed-off-by entries.
156912af0210dccc50d50e8d6dbe7ecc51f0c076: author email (Francois RAMU <[email protected]>) needs to match one of the signed-off-by entries.
ae9098137f2abadaeae4e39fff84dc82a61520f4: author email (Stine Akredalen <[email protected]>) needs to match one of the signed-off-by entries.
8aa5e20515f292469facb801745161808ded7f45: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
7494e04ffb8e52bcddcfec0b647e44c018ffe0f6: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
b117d8e68569082abefb6bc3c8bcd25c6eab496d: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
4546888650c857970b2cef642eb146729f1c28e1: author email (Mateusz Holenko <[email protected]>) needs to match one of the signed-off-by entries.
961705396d85e411ad25528239e0b940bb39bda5: author email (Mateusz Holenko <[email protected]>) needs to match one of the signed-off-by entries.
1fc3858d375ccbba01cd2be3ac24d95fbe208149: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
|
check-warns:
ImageSize.txt#L1
Check the size of image files.
Image file too large: boards/intel/socfpga_std/cyclonev_socdk/doc/img/cyclonev_socdk.jpg reduce size to less than 100kB
|
check-warns:
Pylint.txt#L1
See https://www.pylint.org/ for more details
E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
File:doc/develop/test/twister/sample_blackbox_test.py
Line:13
Column:0
E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
File:doc/develop/test/twister/sample_blackbox_test.py
Line:13
Column:0
E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module)
File:doc/develop/test/twister/sample_blackbox_test.py
Line:13
Column:0
E0611:No name 'other_constants' in module 'constants' (no-name-in-module)
File:scripts/generate_usb_vif/constants/xml_constants.py
Line:8
Column:0
E0611:No name 'vif_element_constants' in module 'constants' (no-name-in-module)
File:scripts/generate_usb_vif/constants/xml_constants.py
Line:8
Column:0
W0611:Unused natsorted imported from natsort (unused-import)
File:scripts/pylib/twister/twisterlib/hardwaremap.py
Line:16
Column:0
E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister/test_harness.py
Line:17
Column:0
E1120:No value for argument 'target' in method call (no-value-for-parameter)
File:scripts/tests/twister/test_platform.py
Line:118
Column:8
E1120:No value for argument 'aliases' in method call (no-value-for-parameter)
File:scripts/tests/twister/test_platform.py
Line:118
Column:8
E1120:No value for argument 'data' in method call (no-value-for-parameter)
File:scripts/tests/twister/test_platform.py
Line:118
Column:8
C0117:Consider changing "not testinstance < testinstance_copy" to "testinstance >= testinstance_copy" (unnecessary-negation)
File:scripts/tests/twister/test_testinstance.py
Line:359
Column:11
C0117:Consider changing "not testinstance_copy < testinstance" to "testinstance_copy >= testinstance" (unnecessary-negation)
File:scripts/tests/twister/test_testinstance.py
Line:360
Column:11
C0201:Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
File:scripts/tests/twister/test_testplan.py
Line:848
Column:37
E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_addon.py
Line:19
Column:0
E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_addon.py
Line:19
Column:0
E0611:No name 'sample_filename_mock' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_addon.py
Line:19
Column:0
E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_addon.py
Line:19
Column:0
E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_disable.py
Line:16
Column:0
E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_disable.py
Line:16
Column:0
E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_disable.py
Line:16
Column:0
E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_quarantine.py
Line:18
Column:0
E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_quarantine.py
Line:18
Column:0
E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module)
File:scripts/tests/twister_blackbox/test_quarantine.py
Line:18
Column:0
I0021:Useless suppression of 'assignment-from-no-return' (useless-suppression)
File:scripts/utils/board_v1_to_v2.py
Line:79
Column:0
E0611:No name 'RC_KERNEL_BIN' in module 'conftest' (no-name-in-module)
File:scripts/west_commands/tests/test_bossac.py
Line:15
Column:0
E0611:No name 'RC_KERNEL_HEX' in module 'conftest' (no-name-in-module)
File:scripts/west_commands/tests/test_stm32cubeprogrammer.py
Line:12
Column:0
E0611:No name 'RC_KERNEL_ELF' in module 'conftest' (no-name-in-module)
File:scripts/west_commands/tests/test_stm32cubeprogrammer.py
Line:12
Column:0
E0611:No name 'RC_KERNEL_ELF' in module 'conftest' (no-name-in-module)
Fil
|
check-warns:
Ruff.txt#L1
Check python files with ruff.
Python lint error (F401) see https://docs.astral.sh/ruff/rules/unused-import:`natsort.natsorted` imported but unused
File:scripts/pylib/twister/twisterlib/hardwaremap.py
Line:16
Column:21
EndLine:16
EndColumn:30
Python lint error (I001) see https://docs.astral.sh/ruff/rules/unsorted-imports:Import block is un-sorted or un-formatted
File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py
Line:4
Column:1
EndLine:10
EndColumn:1
Python lint error (E402) see https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file:Module level import not at top of file
File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py
Line:14
Column:1
EndLine:14
EndColumn:30
Python lint error (E501) see https://docs.astral.sh/ruff/rules/line-too-long:Line too long (104 > 100)
File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py
Line:67
Column:101
EndLine:67
EndColumn:105
Python format error:Run 'ruff format tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py'
File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py
|
check-warns
Process completed with exit code 1.
|
Check for PR description
Process completed with exit code 1.
|
Run Compliance Tests:
doc/develop/test/twister/sample_blackbox_test.py#L13
doc/develop/test/twister/sample_blackbox_test.py:13 No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
|
Run Compliance Tests:
doc/develop/test/twister/sample_blackbox_test.py#L13
doc/develop/test/twister/sample_blackbox_test.py:13 No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
|
Run Compliance Tests:
doc/develop/test/twister/sample_blackbox_test.py#L13
doc/develop/test/twister/sample_blackbox_test.py:13 No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module)
|
Run Compliance Tests:
scripts/generate_usb_vif/constants/xml_constants.py#L8
scripts/generate_usb_vif/constants/xml_constants.py:8 No name 'other_constants' in module 'constants' (no-name-in-module)
|
Run Compliance Tests:
scripts/generate_usb_vif/constants/xml_constants.py#L8
scripts/generate_usb_vif/constants/xml_constants.py:8 No name 'vif_element_constants' in module 'constants' (no-name-in-module)
|
Run Compliance Tests:
scripts/tests/twister/test_harness.py#L17
scripts/tests/twister/test_harness.py:17 No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
|
Run Compliance Tests:
scripts/tests/twister/test_platform.py#L118
scripts/tests/twister/test_platform.py:118 No value for argument 'target' in method call (no-value-for-parameter)
|
Run Compliance Tests:
scripts/tests/twister/test_platform.py#L118
scripts/tests/twister/test_platform.py:118 No value for argument 'aliases' in method call (no-value-for-parameter)
|
Run Compliance Tests:
scripts/tests/twister/test_platform.py#L118
scripts/tests/twister/test_platform.py:118 No value for argument 'data' in method call (no-value-for-parameter)
|
Run Compliance Tests:
scripts/tests/twister_blackbox/test_addon.py#L19
scripts/tests/twister_blackbox/test_addon.py:19 No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
|
Run Compliance Tests:
scripts/pylib/twister/twisterlib/hardwaremap.py#L16
scripts/pylib/twister/twisterlib/hardwaremap.py:16 Unused natsorted imported from natsort (unused-import)
|
Run Compliance Tests:
scripts/tests/twister/test_testinstance.py#L359
scripts/tests/twister/test_testinstance.py:359 Consider changing "not testinstance < testinstance_copy" to "testinstance >= testinstance_copy" (unnecessary-negation)
|
Run Compliance Tests:
scripts/tests/twister/test_testinstance.py#L360
scripts/tests/twister/test_testinstance.py:360 Consider changing "not testinstance_copy < testinstance" to "testinstance_copy >= testinstance" (unnecessary-negation)
|
Run Compliance Tests:
scripts/tests/twister/test_testplan.py#L848
scripts/tests/twister/test_testplan.py:848 Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
|
Run Compliance Tests:
scripts/utils/board_v1_to_v2.py#L79
scripts/utils/board_v1_to_v2.py:79 Useless suppression of 'assignment-from-no-return' (useless-suppression)
|
Loading