[nrf fromlist] scripts: runners: nrf: Check device family #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the nrfjprog runner check the device family before flashing. Otherwise, it is very easy to break some devices that have multiple different chips. (cherry picked from commit e0aa35d74a5aaa6b2fa9f684385c8e8fcda2ad30) Signed-off-by: Maximilian Deubel <[email protected]>
maxd-nordic
force-pushed
the
nrfjprog-family-check-downstream
branch
from
03b9af8 to
b6faf2f
Compare
|
We should have this in place before the new Thingy is shipped since it's mostly relevant for that device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the nrfjprog runner check the device family before flashing. Otherwise, it is very easy to break some devices that have multiple different chips.
(cherry picked from commit e0aa35d74a5aaa6b2fa9f684385c8e8fcda2ad30)
Signed-off-by: Maximilian Deubel [email protected]